I don't use PPPoE but to do NAT I have this in my pf.conf
Code:
# ---- external/egress interface
match out inet from ! egress to any nat-to (egress)
If it still does not work please provide the output (on the pf box) of
# ifconfig -A
and
# netstat -rn -f inet