Quote:
Originally Posted by jsmith6134
"len + want < len" should always be false unless "want" can be negative. If "want" could be negative and that is what the author was trying to detect, then the code should be written:
+ if (want < 0 || !BUF_MEM_grow_clean(b,len+want))
I realize the patch does not show the full source for the file. Am I missing something?
|
Fuller context can be gained by looking at the entire file:
http://www.openbsd.org/cgi-bin/cvswe...otate=1.5.16.1
Having spent only a few minutes looking through the file, it appears that there are overflow conditions the author wants to track as part of error handling. As for whether the expression
len + want < len can be simplified, you should contact the author. Alternatively, you could install
-current, modify the code,
test, & then post the diff on
tech@ for comments.