DaemonForums  

Go Back   DaemonForums > OpenBSD > OpenBSD Installation and Upgrading

OpenBSD Installation and Upgrading Installing and upgrading OpenBSD.

Reply
 
Thread Tools Display Modes
  #1   (View Single Post)  
Old 22nd April 2022
comet--berkeley comet--berkeley is offline
Real Name: Richard
Package Pilot
 
Join Date: Apr 2009
Location: California
Posts: 163
Default OpenBSD 7.1 bad patch 71-001_wifi ?

After upgrading to OpenBSD 7.1 earlier today I ran syspatch and
updated the system using patch 71-001_wifi.

But later now when I run syspatch -c I get this error:

#syspatch -c
syspatch: Error retrieving https://cdn.openbsd.org/pub/OpenBSD/...64/SHA256.sig: 404 Not Found

It seems odd and I looked at the directory,
https://cdn.openbsd.org/pub/OpenBSD/syspatch/
and the 7.1 patch directory is gone!.

It has been renamed to 7.1-no thus triggering the SHA256.sig 404 error...
__________________
When you see a good move, look for a better one.
--Lasker
Reply With Quote
  #2   (View Single Post)  
Old 22nd April 2022
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 7,638
Default

There was an apparent problem with the packaging of the binary syspatch. The patch does what it is supposed to, however, it creates a kernel named "7.1-stable". This causes a problem for reverting the patch or installing new patches with syspatch(8), which only works on releases.

Keep running it if you installed it, as the patch itself works correctly. The Project will have instructions for repair soon.

Source-built patches are not affected.


I haven't seen anything in email, but I saw a post about it just now on Mastodon.
Reply With Quote
  #3   (View Single Post)  
Old 23rd April 2022
comet--berkeley comet--berkeley is offline
Real Name: Richard
Package Pilot
 
Join Date: Apr 2009
Location: California
Posts: 163
Default

Quote:
Originally Posted by jggimi View Post
There was an apparent problem with the packaging of the binary syspatch. The patch does what it is supposed to, however, it creates a kernel named "7.1-stable". This causes a problem for reverting the patch or installing new patches with syspatch(8), which only works on releases.

Keep running it if you installed it, as the patch itself works correctly. The Project will have instructions for repair soon.

Source-built patches are not affected.

I haven't seen anything in email, but I saw a post about it just now on Mastodon.
Thanks jggimi.

Earlier I tried to revert the patch with syspatch -r and that failed, so I reverted it manually:

Code:
#tar -C / -xvf /var/syspatch/71-001_wifi/rollback.tgz
#/usr/libexec/reorder_kernel
And I copied the syspatch directory to syspatch-bad and then removed the syspatch/71-001_wifi directory and its contents.
__________________
When you see a good move, look for a better one.
--Lasker

Last edited by comet--berkeley; 23rd April 2022 at 02:39 AM. Reason: rename rollbackotgz to rollback.tgz
Reply With Quote
  #4   (View Single Post)  
Old 23rd April 2022
jmccue jmccue is offline
Real Name: John McCue
Shell Scout
 
Join Date: Aug 2012
Location: here
Posts: 103
Default

Thanks jggimi, comet--berkeley

I applied it also and will keep an eye on this thread and @misc hoping a fix eventually comes out. If nothing comes out before the next patch (if any), I will follow what comet--berkeley did.

But, does anyone know if comet--berkeley's instructions fix will correct syspatch(8) too ?

At least I am having no issues
__________________
csh(1) - "An elegant shell, for a more... civilized age."
- Paraphrasing Star Wars (tvtropes.org)

Last edited by jmccue; 23rd April 2022 at 02:23 AM. Reason: fixed
Reply With Quote
  #5   (View Single Post)  
Old 23rd April 2022
comet--berkeley comet--berkeley is offline
Real Name: Richard
Package Pilot
 
Join Date: Apr 2009
Location: California
Posts: 163
Default jggimi is correct. The patch does not need to be removed.

Quote:
Originally Posted by jggimi View Post
There was an apparent problem with the packaging of the binary syspatch. The patch does what it is supposed to, however, it creates a kernel named "7.1-stable". This causes a problem for reverting the patch or installing new patches with syspatch(8), which only works on releases.

Keep running it if you installed it, as the patch itself works correctly. The Project will have instructions for repair soon.

Source-built patches are not affected.

I haven't seen anything in email, but I saw a post about it just now on Mastodon.
Quote:
Originally Posted by jmccue View Post
Thanks jggimi, comet--berkeley

I applied it also and will keep an eye on this thread and @misc hoping a fix eventually comes out. If nothing comes out before the next patch (if any), I will follow what comet--berkeley did.

But, does anyone know if comet--berkeley's instructions fix will correct syspatch(8) too ?

At least I am having no issues
Jggimi is correct, the patch is okay to leave in. Theo De Raadt responded to questions about syspatch for 7.1 in the OpenBSD misc mailing list:

Re: Sprurios errors from syspatch -c

Quote:
Originally Posted by Theo de Raadt on misc
The syspatch was accidentally built from the wrong branch, so upon
relinking, it results in a kernel which says it is "7.1-stable".

To prevent application of syspatches to the wrong type of system,
syspatch(8) inspects 'sysctl kern.version'. It checks you have a normal
release system (ie. 7.0 or 7.1). Since this patch renamed the system to
"7.1-stable", syspatch(8) will refuse to install future patches. And of
course the way this check is coded, it won't let you backout the patch
which took the system to 7.1-stable..

Simple instructions for getting over this trouble will be coming along
before there is a new syspatch 001_wifi is made available. I estimate a
week.

People who already installed the 001_wifi syspatch aren't harmed by the
fix otherwise, but I have stopped distribution of the file to reduce the
number of people in this crossed-over state.

(Other than this issue, the syspatch itself was good, it fixes wifi
association problems on a number of devices, so people who already
have it shouldn't take special measures to get rid of it yet, wait for
our advice in a week or so).

And of course, the syspatch testing procedures will get another step or
two to make sure this doesn't happen again....

So just wait.
__________________
When you see a good move, look for a better one.
--Lasker
Reply With Quote
  #6   (View Single Post)  
Old 23rd April 2022
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 7,638
Default

The Project will be publishing a fix for those of us who installed the patch via syspatch(8). One of my -release systems is affected, so I'll be following their guidance when published.
Quote:
Originally Posted by jmccue View Post
...does anyone know if comet--berkeley's instructions fix will correct syspatch(8) too ?
The Project's guidance might be the same. But it could be different. I'm going to wait and see. I would recover my one affected system by restoring from backup, if I was concerned. But I'm not concerned. The only thing impacted by the broken syspatch that has been withdrawn is that it broke syspatch(8).
Reply With Quote
  #7   (View Single Post)  
Old 3rd May 2022
comet--berkeley comet--berkeley is offline
Real Name: Richard
Package Pilot
 
Join Date: Apr 2009
Location: California
Posts: 163
Default The "bad" patch is now good again

The "bad" patch is now good again.

See the 7.1 Errata page for details:

OpenBSD 7.1 Errata
__________________
When you see a good move, look for a better one.
--Lasker
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
LibreSSL - Patch Burden Increases for OpenBSD Developers shep News 1 18th January 2021 11:25 AM
5.9 amd64 kernel panic after 004_mbuf.patch.sig patch shep OpenBSD General 0 2nd May 2016 04:34 PM
Patch for OpenBSD 5.6 httpd(8) J65nko OpenBSD General 12 7th January 2015 12:49 PM
Patch 007 hitest OpenBSD Security 3 7th June 2014 05:17 PM
Patch question Mr-Biscuit Off-Topic 6 4th May 2010 07:47 PM


All times are GMT. The time now is 10:05 PM.


Powered by vBulletin® Version 3.8.4
Copyright ©2000 - 2022, Jelsoft Enterprises Ltd.
Content copyright © 2007-2010, the authors
Daemon image copyright ©1988, Marshall Kirk McKusick