Best moment to send a port update

[albator]

Hi everyone,

Since the Lyx port seems not maintained anymore, I wrote an update myself:

# pkg_info lyx|grep Maintainer  
Maintainer: The OpenBSD ports mailing-list <ports@openbsd.org>

Is it better to wait for the 5.7 version of OpenBSD to be out before sending it to the ports mailing-list? In other words, is the ports tree currently locked?

Thanks

[ocicat]

Originally Posted by albator

...is the ports tree currently locked?

Not any longer for OpenBSD 5.7.

http://marc.info/?l=openbsd-ports&m=142642951115628&w=2

[jggimi]

5.7 is set, and the ports tree was unlocked 15-Mar-2015. You are free to post your update.

However, if I recall correctly you're running 5.6. New port development and port updates must be done on -current. If you've developed your revisions on 5.6, you will need to test with -current, and your diffs must apply to the -current tree.

The port is still maintained, even if it is an older release of Lyx. There have been two commits to the port since 5.6-release.

[ibara]

Originally Posted by albator

Since the Lyx port seems not maintained anymore

It's not unmaintained, it means that maintenance falls to the community rather than a specific individual. It's a subtle shifting of problem statement but I think it's a valuable one.

Originally Posted by albator

I wrote an update myself

Great! Then the system works as intended.

Consider taking maintainership of Lyx.

[Oko]

Originally Posted by albator

Is it better to wait for the 5.7 version of OpenBSD to be out before sending it to the ports mailing-list? In other words, is the ports tree currently locked?

Thanks

I am not a developer but have rudimentary understanding of OpenBSD developmental cycle. This is the best time to send new ports and updates. Namely for the past 2 weeks OpenBSD was unlocked and it is in the midst of the most vigorous development which will hopefully end up as 5.8. The development will slow down sometime in after the May and get into 5.8 debug and release mode.

[jggimi]

Debug and release preparation for 5.8 won't being until "-beta," which I predict (based on when -beta began for 5.6, 5.4, and 5.2) should occur in July. And if past performance is a predictor, the Project will continue with development of key features even during this period.

See FAQ 5.1 - OpenBSD's Flavors for a good explanation of the six-month release development cycle.

[albator]

Thank you all for your replies and your clarifications.

Jggimi, your memory is impressive! You're right I am running stable. But I installed -current on a spare (and slow) machine to make this update.
In fact, there are very few changes and the port works both on 5.6 and -current. I'll send the update to the mailing-list.

Thanks again

[jggimi]

I'm currently testing your submitted update on i386 since you have already tested on amd64. I'm on a second rebuild; the first time the package failed a lib-depends-check but I believe that was because I'd had the committed port installed when I built it. I then uninstalled and am currently rebuilding. I should be able to report results tomorrow.

[albator]

Thanks Jggimi for testing this update.

This is my first modification to a port, and I might do things the wrong way. As my machine is very slow, here is what I did :
- installed the current package with pkg_add.
- deleted it with pkg_delete (no pkg_delete -a next). Which means all the dependencies are still there.
- Installed the port with my changes.

[jggimi]

My i386 machine is even slower.

The lib-depends-check did fail properly. The updated tex2lyx program now requires devel/libmagic. I've added it as a LIB_DEPENDS and as a RUN_DEPENDS, and will let it rebuild. I've started a new build, but I won't be able to check its results until about 10 hours from now.

[albator]

Here is an extract of Lyx 2.1.3 RELEASE-NOTES:
LyX now links against libmagic [...] if it is available at compile time. [...]
The old builtin format detection code is used if libmagic is not available.

Extract of configure:
### check for file magic support (currently optional)
[...]
lyx_warning_txt="$lyx_warning_txt
== cannot find libmagic. Please check that the libmagic library
is correctly installed on your system.
Falling back to builtin file format detection.
"
lyx_warning=yes
fi
else
lyx_warning_txt="$lyx_warning_txt
== cannot find magic.h. Please check that the libmagic library
is correctly installed on your system.
Falling back to builtin file format detection.
"
lyx_warning=yes
fi

libmagic does not seem to be mandatory and is not installed on my system. magic.h is installed though, but this seems optional too:

# find / -name "*libmagic*"
/usr/ports/devel/libmagic
/usr/ports/devel/py-libmagic
# pkg_info|grep libmagic
# 
# find / -name "*magic.h*"
/usr/local/include/ImageMagick/magick/magic.h

I'll remove all packages and try to buid Lyx again. We'll see who has the slowest machine!

[ibara]

Originally Posted by jggimi

I've added it as a LIB_DEPENDS and as a RUN_DEPENDS

You don't need both. LIB_DEPENDS is all you need.

Originally Posted by albator

Here is an extract of Lyx 2.1.3 RELEASE-NOTES:
LyX now links against libmagic [...] if it is available at compile time. [...]
The old builtin format detection code is used if libmagic is not available.

You will need to either add an LDEP on libmagic and make sure it is picked up during configure or disable libmagic (likely by way of a configure arg). My guess is the former is the better approach.

Originally Posted by albator

libmagic does not seem to be mandatory and is not installed on my system. magic.h is installed though, but this seems optional too:

That is for something else. Don't play with it.

[jggimi]

I'll guess that the optional library should be mandatory as it is available in the ports tree, and if tex2lyx works with it.

Ports are bulk built by the Project for -releases and -current. Those builds are done with dpb(1), so the specific mix of any independent packages that might be installed on any particular build machine in the server farm at build time cannot be predicted. We can only be assured of dependent packages. My assumption is the members want consistent builds with consistent results.

We'll see who has the slowest machine!

Atom N270. I think I have you beat for slowest.

[albator]

Originally Posted by jggimi

Atom N270. I think I have you beat for slowest.

Celeron M520. Damn, you win! Not by much though. And mine must get hotter ;-)
TDP: 2.5 W vs 30 W

[jggimi]

Ho-kay. All done. Out of band, ibara recommended port-lib-depends-check over lib-depends-check. That recommended both LDEP and WANTLIB.

--- Makefile    Mon Mar 30 19:21:51 2015
+++ makefile    Tue Mar 31 18:37:08 2015
@@ -23,12 +23,13 @@
 
 LIB_DEPENDS=    ${MODQT4_LIB_DEPENDS}>=4.5.3 \
         devel/boost \
+        devel/libmagic \
         textproc/enchant \
         textproc/aspell/core
 
 WANTLIB += lib/qt4/QtGui>=8 aspell c m pthread stdc++ z
 WANTLIB += boost_regex-mt>=1 boost_signals-mt>=1
-WANTLIB += glib-2.0 gmodule-2.0 enchant
+WANTLIB += glib-2.0 gmodule-2.0 enchant magic
 
 SEPARATE_BUILD=    Yes
 USE_GMAKE=    Yes

Lyx works fine on i386, and I will post this to ports@.

I have never used .tex files, so I haven't a clue what to do with tex2lyx.

[albator]

I started again from scratch, with no packages at all, to see if the same problem happens on amd64. It's been running for 14 hours... What is a good starting point before testing a port, should one delete all other related packages first? In this particular case, there wouldn't be many left.

Anyway you're right about adding libmagic. Is it better to send a new diff to ports@including the changes you've already sent?
Before that, I will build it again with the new Makefile.

Are you going to produce .tex files, so that you can use tex2lyx?

[jggimi]

The Porter's Handbook doesn't explicitly recommend clean-slate building. It does say we need to know the software, and Step 26 of its Porting Checklist states:

Verify dependencies. Peruse your logs to verify the port did detect what is mentioned in DEPENDS, and nothing more. Check names, particularly in the make configure stage, for hidden dependencies (stuff that exists elsewhere in the ports tree and might be detected if the user installs some other ports first).

What I mentioned above regarding Project builds with dpb(1) is also true for all users who install the package or build from the port: we can never be sure of the previously installed package set on any machine.

---

My machine is so slow that when I need to build a port, I install all build dependencies (if available) from packages:

# pkg_add -az `make full-build-depends`

[jggimi]

I missed two questions.

Originally Posted by albator

IIs it better to send a new diff to ports@including the changes you've already sent?

When you "ping" the ports@ mailing list to ask for additional testing, review, or commit, you can submit a revised port. If it gets committed before then, libmagic will likely be included.

Are you going to produce .tex files, so that you can use tex2lyx?

No, because I don't want to learn how to write TeX (or LaTeX) markup just for one little test.

[IdOp]

Originally Posted by jggimi

I don't want to learn how to write TeX (or LaTeX) markup just for one little test.

There's always this, hw.tex:

Hello, world.

\bye

Enjoy.

[jggimi]

Enjoyed.

I can report tex2lyx with libmagic works on i386.