DaemonForums  

Go Back   DaemonForums > OpenBSD > OpenBSD Packages and Ports

OpenBSD Packages and Ports Installation and upgrading of packages and ports on OpenBSD.

Reply
 
Thread Tools Display Modes
Old 28th February 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

At -release, this appears to be either an error in function or an error in documentation. There have been no -stable patches to src/usr.sbin/httpd/ committed, but there have been changes for -current, which is why that should be the next test.

If you want, you can test in -current now.
Reply With Quote
Old 28th February 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

I had some time and recreated the problem on -current.

How's your C? Would you like to walk through the source code?
Reply With Quote
Old 28th February 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

This is interesting. When built with DEBUG=3 (httpd developer debug mode, commented out in the Makefile), the problem is not reproducible. I have run out of time to investigate further today.
Reply With Quote
Old 1st March 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

I went back and rebuilt the httpd module from -current source, and now cannot reproduce the problem on -current. I saw it with a recent snapshot, but not with httpd rebuilt from -current source.

I'll spend some time on this over the weekend looking at commits between -release and -current, and see if I can determine which commit resolved the problem.
Reply With Quote
Old 1st March 2018
toprank toprank is offline
Fdisk Soldier
 
Join Date: Feb 2018
Posts: 52
Default

Thanks, jggimi. I'm afraid I don't think I'd be much help parsing the source code but, nonetheless, would be happy to do so with you if you like?

I was going to say, I'd hazard a guess that it's a bug in the operation not the documentation.

Also, I'm surprised that this hasn't been picked up earlier. Could it be that it's a recently introduced bug; that is, up until a recent commit it did function as expected? Because surely someone ran into real problems in production with this fault? It's a pretty significant service disruption.
Reply With Quote
Old 1st March 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

At this time, it looks to me as if:
  • The problem was reproduced in the last snapshot.
  • The problem resolved itself when I built the httpd module from -current source.
I will need to do further testing. I'm not sure at this time if what I saw when testing yesterday is itself reproducible.
Reply With Quote
Old 1st March 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

I have retested in the -current snapshot, with the snapshot's binary of /usr/sbin/httpd, and could not reproduce the problem.

It appears, now, that this has been fixed in -current.

I do not know why my first test in -current appeared to reproduce the problem.
Reply With Quote
Old 1st March 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

OK. I *think* I have narrowed it down to the number of prefork servers provisioned. It's just a guess at this point. I have $DAYJOB, and other duties, so will not be able to continue testing until next week.
Reply With Quote
Old 2nd March 2018
toprank toprank is offline
Fdisk Soldier
 
Join Date: Feb 2018
Posts: 52
Default

You've done a lot already. It's an interesting find. I mean, it looks like it previously worked as the documentation suggests it should, then broke, but hadn't been picked up till now. I'm looking forward to not only seeing it fixed but understanding why it broke.
Reply With Quote
Old 2nd March 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

It's not clear to me, yet, under what conditions it fails. I planned to begin trying to isolate those conditions when it would fail or not fail, but I won't have time to start until next week.

I tripped over my own assumptions regarding DEBUG settings. And I haven't had enough time to research this completely. I have not walked through the code yet, only noted in which modules the variable maxrequestbody gets set, and where it gets tested.

I hope, next week, to study the conditions under which the bug appears, and step through the code line by line, and compare that with the code path taken in conditions where the bug does not manifest.

I'm not a developer, and have only just begun delving into this program.
Reply With Quote
Old 2nd March 2018
toprank toprank is offline
Fdisk Soldier
 
Join Date: Feb 2018
Posts: 52
Default

You've done well getting this far already. Is the developer aware of this bug yet?
Reply With Quote
Old 2nd March 2018
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 6,188
Default

I've not informed any of the developers because I am not able to prepare a useful bug report, yet.
Reply With Quote
Reply

Tags
httpd, mariadb, mysql, nextcloud, php

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
httpd rc.conf.local question psypro OpenBSD General 3 30th October 2016 05:54 PM
httpd.conf chroot morophla OpenBSD General 4 19th April 2015 02:07 PM
ipsec.conf & IKE mode config pyzo OpenBSD Security 1 24th May 2012 05:06 AM
Update httpd.conf IPs from DNS zones. bigb89 Programming 16 2nd December 2008 02:02 AM
httpd.conf Snoop1990 General software and network 5 29th July 2008 04:30 AM


All times are GMT. The time now is 01:58 PM.


Powered by vBulletin® Version 3.8.4
Copyright ©2000 - 2018, Jelsoft Enterprises Ltd.
Content copyright © 2007-2010, the authors
Daemon image copyright ©1988, Marshall Kirk McKusick