DaemonForums  

Go Back   DaemonForums > OpenBSD > OpenBSD General

OpenBSD General Other questions regarding OpenBSD which do not fit in any of the categories below.

Reply
 
Thread Tools Display Modes
  #1   (View Single Post)  
Old 24th July 2008
sam-i-am sam-i-am is offline
New User
 
Join Date: Jul 2008
Posts: 2
Thanked 0 Times in 0 Posts
Default problem applying patch

I run OpenBSD 4.2 release, and keep it up to date applying patches per the errata page. http://openbsd.org/errata42.html - 013: SECURITY FIX: July 23, 2008 2nd revision.

Attempting to apply the very important bind patch, I found it would not compile. So I reversed the patch, to check if the original version would compile. I even download the source again to check if a clean version would compile.

In both cases I get the same error:

Code:
cc  -I/usr/src/usr.sbin/bind/obj -I. -Iinclude -I/usr/src/usr.sbin/bind/obj/lib/dns/include  -I/usr/src/usr.sbin/bind/lib/dns/include  -I/usr/src/usr.sbin/bind/obj/lib/isc/include  -I/usr/src/usr.sbin/bind/lib/isc  -I/usr/src/usr.sbin/bind/lib/isc/include  -I/usr/src/usr.sbin/bind/lib/isc/unix/include  -I/usr/src/usr.sbin/bind/lib/isc/nothreads/include    -DUSE_MD5 -DOPENSSL  -O2 -pipe   -W -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wformat -Wpointer-arith -fno-strict-aliasing  -c /usr/src/usr.sbin/bind/lib/dns/acl.c
In file included from /usr/src/usr.sbin/bind/lib/dns/include/dns/types.h:154,
                 from /usr/src/usr.sbin/bind/lib/dns/include/dns/name.h:82,
                 from /usr/src/usr.sbin/bind/lib/dns/include/dns/acl.h:40,
                 from /usr/src/usr.sbin/bind/lib/dns/acl.c:26:
include/dns/enumtype.h:77: error: redefinition of `dns_rdatatype_dlv'
include/dns/enumtype.h:76: error: `dns_rdatatype_dlv' previously defined here
*** Error code 1

Stop in /usr/src/usr.sbin/bind/obj/lib/dns.
*** Error code 1

Stop in /usr/src/usr.sbin/bind/obj/lib (line 99 of Makefile).
*** Error code 1

Stop in /usr/src/usr.sbin/bind/obj (line 97 of Makefile).
*** Error code 1

Stop in /usr/src/usr.sbin/bind (line 54 of /usr/src/usr.sbin/bind/Makefile.bsd-wrapper).
Indeed in /usr/obj/usr.sbin/bind/lib/dns/include/dns/enumtype.h, which is generated by the compile process, that data definition is there twice...

Code:
/***************
 ***************
 ***************   THIS FILE IS AUTOMATICALLY GENERATED BY gen.c.
 ***************   DO NOT EDIT!
 ***************
 ***************/
.
.
<snip>
.
.
        dns_rdatatype_dlv = 32769,
        dns_rdatatype_dlv = 65323,
.
.
.
At that point I am stuck.

I don't know how to work out how the build process generates that file (athough make clean gets rid of it).
I don't know which value is correct, even if I do work out how that file gets generated.

I figure I am not the only person who has attempted to apply this patch, and I can't find any other reports of it on Google, so it's unlikely to be a general problem associated with the 'release' or 'stable' version, and is probably something specific to my systems' build options, which is causing this error. But what?

Thanks in advance if you can assist.

Cheers
Sam
Reply With Quote
  #2   (View Single Post)  
Old 24th July 2008
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 3,709
Thanked 214 Times in 189 Posts
Default

Be sure you are using Revision 2 of the patch:

ftp://ftp.openbsd.org/pub/OpenBSD/pa...004_bind.patch
Reply With Quote
  #3   (View Single Post)  
Old 24th July 2008
jggimi's Avatar
jggimi jggimi is offline
More noise than signal
 
Join Date: May 2008
Location: USA
Posts: 3,709
Thanked 214 Times in 189 Posts
Default

Ooops. I gave you the 4.3 patch link. Here's the 4.2 patch link instead:

ftp://ftp.openbsd.org/pub/OpenBSD/pa...013_bind.patch
Reply With Quote
  #4   (View Single Post)  
Old 25th July 2008
sam-i-am sam-i-am is offline
New User
 
Join Date: Jul 2008
Posts: 2
Thanked 0 Times in 0 Posts
Default

Yeah the patch applied just fine, and as I said, when I reversed the patch, it still would not compile, so it's just that this particular issue has highlighted a problem.

Weirdly I checked out the sources from CVS...

cvs checkout -P -rOPENBSD_4_2 src

(a) the patch is already there in stable
(b) the CVS sources compile without an error.

Since it's working I'm happy and feel protected

And a lesson learned perhaps... better to use CVS and run stable rather than running release and applying patches.

Cheers
Richard
Reply With Quote
  #5   (View Single Post)  
Old 25th July 2008
BSDfan666 BSDfan666 is offline
Real Name: N/A, this is the interweb.
Helpful companion
 
Join Date: Apr 2008
Location: Ontario, Canada
Posts: 2,223
Thanked 193 Times in 184 Posts
Default

I don't know about that, I've been following release+patches for awhile now.. no issues so far, I may miss out on some of the stable back ports, but I rest assured important changes will be made available at a time convenient to the developers.
Reply With Quote
Reply

Tags
bind patch, errata 4.2

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
FreeBSD 7.2 X Server 1.6 Patch dialeight FreeBSD Installation and Upgrading 1 4th August 2009 04:25 PM
Following Stable. Why uname does NOT show patch #6. Greg_Morgan OpenBSD Installation and Upgrading 4 20th May 2009 06:21 AM
patch application for usb mouse? aesop FreeBSD Installation and Upgrading 1 17th January 2009 11:15 PM
CoOrdinated DNS Vulnerablility Patch. robbak General software and network 13 15th July 2008 01:05 PM
PATCH errors during portupgrade shinjii FreeBSD Installation and Upgrading 4 23rd June 2008 02:47 AM


All times are GMT. The time now is 07:01 PM.


Powered by vBulletin® Version 3.8.4
Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content copyright © 2007-2010, the authors
Daemon image copyright ©1988, Marshall Kirk McKusick