New Kernel: "make depend" doesn't work

[nihonto]

Hi there,

I'm trying to compile a new kernel on NetBSD-4.0.1. But when it comes to "make depend" I get this error:

# make depend
make: "/etc/mk.conf" line 207: Malformed conditional ((!empty(MACHINE_PLATFORM:MNetBSD-*-*) && exists(/usr/X11R7/lib/libX11.so)))
make: "/etc/mk.conf" line 207: Need an operator
make: "/etc/mk.conf" line 210: Malformed conditional (empty(MACHINE_PLATFORM:MDarwin-9.*-*) || (defined(X11_TYPE) && ${X11_TYPE} != "native"))
make: "/etc/mk.conf" line 516: Malformed conditional (${OPSYS} == "IRIX")
make: "/etc/mk.conf" line 516: Need an operator
make: "/etc/mk.conf" line 529: Malformed conditional (${OPSYS} == "SunOS")
make: Fatal errors encountered -- cannot continue

make: stopped in /usr/src/sys/arch/i386/compile/MYKERNEL

What is ment by "Malformed conditional"? And what kind of "operator" is expected?

I have copied the example from /usr/pkgsrc/mk/defaults/mk.conf to /etc. So I thought it should be ok.

Any ideas?

[Oko]

It looks to me like you need to set up in your /etc/mk.conf file the type of architecture you are compiling kernel for. NetBSD can be cross compiled so it probably makes no assumption that if you are compiling kernel on AMD64 it is going to be used on AMD64.

[nihonto]

Originally Posted by Oko

It looks to me like you need to set up in your /etc/mk.conf file the type of architecture you are compiling kernel for.

Hi Oko,

thanks for your hint! I will look it up, when I'm home from work this evening. This example mk.conf from pkgsrc is a quite long document and I haven't read it in total.

In fact up to now I just used it for building xorg and for several ACCEPTABLE_LICENSE details.

[s0xxx]

@nihonto

Did you add any extra options to /etc/mk.conf or you just copied it over to /etc and did a 'make depend'?
Also, try deleting the content of mk.conf file and put only stuff you need, there is no need for default options to be listed, and it's way clearer for reading.

[nihonto]

Originally Posted by s0xxx

@nihonto

Did you add any extra options to /etc/mk.conf or you just copied it over to /etc and did a 'make depend'?
Also, try deleting the content of mk.conf file and put only stuff you need, there is no need for default options to be listed, and it's way clearer for reading.

I didn't add any extra options. I just needed the mk.conf for building modular xorg:

X11_TYPE=modular

And I need the mk.conf because several packages need an entry in mk.conf while building them with pkgsrc. For example Opera needs an entry a la

ACCEPTABLE_LICENSES += opera-license

I copied the /usr/pkgsrc/mk/defaults/mk.conf to /etc because I thought this would be the "right" way.

By the way - what does the "+" sign mean in front of the equals sign? And I have even seen question marks in front of the equals sign like here:

PACKAGES?= ${PKGSRCDIR}/packages

What do they indicate?

[nihonto]

Well, this evening I have chosen the easy solution. I have moved /etc/mk.conf to /etc.mk.conf.old and created a new empty mk.conf.

In this new document I placed only entries, that I know I need:

ALLOW_VULNERABLE_PACKAGES=defined
X11_TYPE=modular
ACCEPTABLE_LICENSES+=opera-850-license vim-license

After that the kernel compiled without any problems!

[s0xxx]

Originally Posted by nihonto

By the way - what does the "+" sign mean in front of the equals sign? And I have even seen question marks in front of the equals sign. What do they indicate?

From a make(1) man page:

VARIABLE ASSIGNMENTS
     Variables in make are much like variables in the shell, and, by tradi-
     tion, consist of all upper-case letters.

   Variable assignment modifiers
     The five operators that can be used to assign values to variables are as
     follows:

     =       Assign the value to the variable.  Any previous value is overrid-
             den.

     +=      Append the value to the current value of the variable.

     ?=      Assign the value to the variable if it is not already defined.

     :=      Assign with expansion, i.e. expand the value before assigning it
             to the variable.  Normally, expansion is not done until the vari-
             able is referenced.  NOTE: References to undefined variables are
             not expanded.  This can cause problems when variable modifiers
             are used.

     !=      Expand the value and pass it to the shell for execution and
             assign the result to the variable.  Any newlines in the result
             are replaced with spaces.

http://netbsd.gw.com/cgi-bin/man-cgi...NetBSD-current

[nihonto]

Originally Posted by s0xxx

From a make(1) man page: ...

Ahhh, there is a description of the signs. I looked up mk.conf (5) and couldn't find anything.

That's the trick with manpages - you have to know which one solves your needs.

[J65nko]

RE: "Malformed conditional". The following, done on OpenBSD, explains this error

# cat -n Makefile ; make 
     1  #OPSYS = IRIX
     2  
     3  .if ( ${OPSYS} == "IRIX" )
     4  message:
     5          @echo Yes the operating system is IRIX!
     6  .endif
     7  
"Makefile", line 3: Malformed conditional (( ${OPSYS} == "IRIX" ))
"Makefile", line 3: Missing dependency operator
"Makefile", line 6: if-less endif
"Makefile", line 6: Need an operator
Fatal errors encountered -- cannot continue

Removal of the comment indicator '#' from line 1 and thus having a variable OPSYS defined, there is no error at all

$ cat -n Makefile ; make 
     1  OPSYS = IRIX
     2  
     3  .if ( ${OPSYS} == "IRIX" )
     4  message:
     5          @echo Yes the operating system is IRIX!
     6  .endif
     7 
 
Yes the operating system is IRIX!

RE: "need an operator" error

A more common cause for the "need an operator" message is using a spaces instead of the required tab in the shell command line (here lines 2-3):

$ cat -nt Makefile                  
     1  message: 
     2  ^I@echo "Yes the operating system is IRIX!"
     3  ^I@echo "===" 
     4  
Yes the operating system is IRIX!
===

Here the required tabs displayed as '^I', short for CONTROL-I, are present. An expansion of this tab into spaces, for instance caused by a cut and paste operation, produces the "need an operator" error:

$ cat -nt Makefile ; make           
     1  message: 
     2          @echo "Yes the operating system is IRIX!"
     3          @echo "===" 
     4  
"Makefile", line 3: Need an operator
Fatal errors encountered -- cannot continue

[s0xxx]

As for the error, I found this thread, check Hubert Feyrer's response: http://arkiv.netbsd.se/?ml=netbsd-te...05-01&t=592114